This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
ci: sidecar images updates will be also created for latest bugfix branch #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykhailo Kuznietsov <[email protected]>
mkuznyetsov
requested review from
benoitf,
ericwill,
JPinkney,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
nickboldt
reviewed
Jun 30, 2021
| @@ -77,6 +88,7 @@ if [[ $(git diff --exit-code "${SCRIPT_DIR}"/base_images) ]]; then | |||
| else | |||
| echo "[INFO] Changes detected, generating PR with new digests" | |||
| createPR "new-base-image-digests" | |||
| create | |||
nickboldt
reviewed
Jun 30, 2021
nickboldt
reviewed
Jun 30, 2021
| @@ -72,4 +72,5 @@ jobs: | |||
| git config --global user.name "Mykhailo Kuznietsov" | |||
| git config --global user.email "[email protected]" | |||
| export GITHUB_TOKEN=${{ secrets.CHE_BOT_GITHUB_TOKEN }} | |||
| ./arbitrary-users-patch/check_sidecar_image_digests.sh | |||
| BUGFIX_BRANCH="$(git branch -a | grep "remotes/origin/7.*" | cut -d '/' -f 3 | sort --version-sort | tail -n1)" | |||
There was a problem hiding this comment.
what if a topic branch is created called 7.32.x-some-reason? will that be used instead of 7.32.x ?
There was a problem hiding this comment.
right, I should add protection from that
|
We are planning to decouple the dev container images from the Che release lifecycle, so I'm not sure how much more time you want to invest in this PR. |
|
@ericwill are you saying this PR is now moot? If so, feel free to just close it and add a comment on its related issue: eclipse-che/che#19695 |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykhailo Kuznietsov [email protected]
What does this PR do?
When we create updates for sidecar images into main branch, they must be also cherry-picked into bugfix branch (as bugfix releases will remain broken otherwise). With this PR, the job will also create PR for latest bugfix branch
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.